Skip to content
This repository has been archived by the owner on Jan 6, 2021. It is now read-only.

build: add coverage folder to eslintignore #24

Merged
merged 1 commit into from Feb 4, 2019
Merged

build: add coverage folder to eslintignore #24

merged 1 commit into from Feb 4, 2019

Conversation

mgred
Copy link
Contributor

@mgred mgred commented Feb 4, 2019

Purpose (TL;DR) - mandatory

As of all projects add the coverage folder to .eslintignore to be not linted

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. npm run test-coverage
  4. npm run lint
  5. See no lint errors anymore 馃槈

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@mgred mgred self-assigned this Feb 4, 2019
@coveralls
Copy link

coveralls commented Feb 4, 2019 •
edited

Pull Request Test Coverage Report for Build 97

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.951%
Totals Coverage Status
Change from base Build 93: 0.0%
Covered Lines: 92
Relevant Lines: 110
馃挍 - Coveralls

@mgred mgred requested a review from mantoni February 4, 2019 14:52
@mgred mgred merged commit 7455a2c into master Feb 4, 2019
@mgred mgred deleted the eslintignore-coverage branch February 4, 2019 15:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mantoni mantoni mantoni approved these changes

Assignees

@mgred mgred

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mgred @coveralls @mantoni