Import from sinon #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses more of eslint-plugin-mocha than `sinonjs/sinon` currently uses. These are the rules that there seemed to be consensus for in sinonjs/sinon#1426
1 task
|
Great stuff! Is the use of JSDOM in the tests new? |
|
Yep. It's (mostly) easier than dealing with real browsers. I thought it would a good opportunity to make things easier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeds the
niserepository with the extracted modules I've been working on.Once we are happy that this is working, we can publish a first version, and integrate it into
sinonjs/sinonThe API for the first version tries to stay as close to the original API from
sinonjs/sinon, this is probably not how it should look in the future. Let's just get this separated first, and then put out a new version with a better API.To verify
npm installnpm testnpm run bundle