Prepare project for a new life as a Sinon.JS project #7
Conversation
.npmrc
Outdated
| @@ -0,0 +1 @@ | |||
| save-exact=true | |||
There was a problem hiding this comment.
This is what package-lock.json is for. If we have fixed versions for dependencies, not even patches would be updated on a fresh install of this module.
There was a problem hiding this comment.
Some projects published to npm do not follow semver. I got bitten by this recently, and the reply was basically that they didn't care about it
There was a problem hiding this comment.
Was it one of the dependencies of this project?
There was a problem hiding this comment.
It was a dependency of one of the @sinonjs projects, trying to find it now
There was a problem hiding this comment.
I would argue that only the one dependency, where the maintainers use npm without following the official npm semantics, should be a fixed version. Giving up on semver entirely just because someone else doesn't like it means we're actively helping to kill it.
There was a problem hiding this comment.
Good to know. I also depend on them in some projects. Do we have an alternative module?
There was a problem hiding this comment.
I don't think that any of the sinonjs projects need to ship minified versions at all. I'd be happy to remove it from sinon-test, and then update all repositories to use default npm behaviour (which I am not a huge fan of, but it's the well beaten path)
There was a problem hiding this comment.
I'll update this PR to remove that commit, and set dependencies back to normal
Remove support for `callOrder`, as that was removed in `sinon@3`
| # https://github.com/nodejs/LTS | ||
| - "4" # ends April 2018 | ||
| - "6" # ends April 2019 | ||
| - "8" # ends December 2019 |
|
Thank you :) |
This PR fixes most of the tasks in #6