Matcher documentation #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 25 25
Lines 498 498
=====================================
Hits 498 498
Continue to review full report at Codecov.
|
mroderick
approved these changes
Oct 16, 2019
|
|
||
| Requires the value to strictly equal `ref`. | ||
|
|
||
| #### `sinon.match.typeOf(type)` |
There was a problem hiding this comment.
We can further improve samsam to support all the types that type-detect can detect: https://github.com/chaijs/type-detect#readme
There was a problem hiding this comment.
Yes, that would be very easy to do. 👍
There was a problem hiding this comment.
I wonder why we use sinon.match and not samsam.match on all of these. Seems super weird when reading the docs under the assumption that this is a standalone library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Some quick and easy documentation improvements