You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR contains the set of changes for samsam 3 that have been collected on the next branch.
The changes should be downward compatible, but given the scope, I'd like to release this as a major. This will also allow to make a clean switch in Sinon.
How to verify - mandatory
Check out this branch
npm install
npm t
Checklist for author
npm run lint passes
References to standard library functions are cached.
* Integrate sinon.match with samsam.match
* Integrate samsam.match with samsam.deepEqual
* Simplify deepEqualCyclic by swapping actual and expected
* Order exported functions alphabetically
* More consistent formatting in test case
* Group positive and negative tests
* Rename sinon-match.js to matcher.js
This might need a little more work. A first attempt to integrate this with Sinon causes 6 tests to fail. We can keep this PR open for discussion and tracking the changes.
It turns out that Sinon calls samsam.deepEqual(expected, actual) instead of (actual, expected). With matcher integration, deepEqual is not symetric, so order matters. Swapping the arguments in all occurences of deepEqual in Sinon makes all tests pass.
I'm surprised how clean this went. I replace the entire lib/sinon/util/core/deep-equal.js with samsam.deepEqual and lib/sinon/match.js with samsam.createMatcher.
Given that referee uses (actual, expected) semantics, I'd like to keep this implementation here as is. It's a major release anyway and the changes in Sinon are straight forward.
BREAKING: This brings the samsam.match implementation closer to how
sinon.match behaves. Nested object where recursively compared using
samsam.match itself. This change uses samsam.deepEqual for recursive
checks instead. If matching logic is desireable on nested objects,
samsam.createMatcher can be used which is now recognized.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
This PR contains the set of changes for samsam 3 that have been collected on the
nextbranch.The changes should be downward compatible, but given the scope, I'd like to release this as a major. This will also allow to make a clean switch in Sinon.
How to verify - mandatory
npm installnpm tChecklist for author
npm run lintpasses