Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactorings #75

Merged
merged 4 commits into from Aug 9, 2019
Merged

Refactorings #75

merged 4 commits into from Aug 9, 2019

Conversation

mgred
Copy link
Contributor

@mgred mgred commented Aug 3, 2019 •
edited

Purpose (TL;DR) - mandatory

Some refactorings I did a while ago and forgot about 馃槄 Hope this still makes sense

This mainly uses functionality from the @sinon/commons package now.

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. npm run test

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@mgred mgred self-assigned this Aug 3, 2019
@mgred mgred requested a review from mantoni August 3, 2019 11:45
@coveralls
Copy link

coveralls commented Aug 3, 2019 •
edited

Pull Request Test Coverage Report for Build 294

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.7%) to 97.997%
Files with Coverage Reduction New Missed Lines %
matcher.js 1 99.41%
deep-equal.js 2 97.44%
Totals Coverage Status
Change from base Build 287: 0.7%
Covered Lines: 460
Relevant Lines: 468
馃挍 - Coveralls

@mgred mgred mentioned this pull request Aug 3, 2019
Closed
2 tasks
mantoni
mantoni reviewed Aug 9, 2019
View reviewed changes
Copy link
Member

@mantoni mantoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just one minor question.

lib/deep-equal.js Show resolved Hide resolved
@mroderick
Copy link
Member

Very nice!

@mgred mgred merged commit 368386c into master Aug 9, 2019
@mgred mgred deleted the refactorings branch August 9, 2019 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantoni mantoni mantoni approved these changes

Assignees

@mgred mgred

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mgred @coveralls @mroderick @mantoni