Upgrade ESLint and all dependencies #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroderick
force-pushed
the
upgrade-eslint
branch
2 times, most recently
from
d45f474
to
323fe76
Compare
mroderick
changed the title
Pull Request Test Coverage Report for Build 307
馃挍 - Coveralls |
mroderick
force-pushed
the
upgrade-eslint
branch
2 times, most recently
from
db0466b
to
9095be1
Compare
In order to prepare for future improvements, where the `local-rules/no-prototype-methods` eslint rule detects errors, we upgrade @sinonjs/commons to a version that has cached references to `Map` and `Set`.
In order to satisfy `local-rules/no-prototype-methods`
In order to satisfy `local-rules/no-prototype-methods`
In order to satisfy `local-rules/no-prototype-methods`
In order to satisfy `local-rules/no-prototype-methods`
In order to satisfy `local-rules/no-prototype-methods`
In order to satisfy `local-rules/no-prototype-methods`
This allows us to lint for uncached uses of the object prototypes, which can be stubbed in userland code.
This allows ESLint to detect when uncached references to prototypes are
used.
* Install eslint-plugin-local-rules plugin
* Configure ESLint to use plugin
* Ignore errors in tests
As this can take many different forms
In preparation of upgrading to `eslint@latest` and `eslint-config-sinon@latest`
In preparation of upgrading to `eslint@latest` and `eslint-config-sinon@latest`
In preparation of upgrading to `eslint@latest` and `eslint-config-sinon@latest`
In preparation of upgrading to `eslint@latest` and `eslint-config-sinon@latest`
In preparation of upgrading to `eslint@latest` and `eslint-config-sinon@latest`
* And all related plugins and configs * Update eslintrc.yaml to meet `eslint@6` required format
mroderick
force-pushed
the
upgrade-eslint
branch
from
9095be1
to
1bb5e5e
Compare
mantoni
reviewed
Aug 21, 2019
| @@ -74,6 +74,7 @@ function propertyMatcherTests(matcher, additionalTests) { | |||
| it("compares with matcher", function() { | |||
| var has = matcher("callback", createMatcher.typeOf("function")); | |||
|
|
|||
| // eslint-disable-next-line no-empty-function | |||
There was a problem hiding this comment.
I think you can alternatively write function () { /* empty */ }. Just sayin, no need to change here.
mantoni
reviewed
Aug 21, 2019
| @@ -0,0 +1,79 @@ | |||
| "use strict"; | |||
There was a problem hiding this comment.
Isn't this something we'd need in all projects? Shouldn't it live in the sinon eslint project?
There was a problem hiding this comment.
It is. In the interest of getting this moving, I opted for a bit of duplication, until we figure out how to get it distributed properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades ESLint and all related packages to latest versions.
Purpose (TL;DR)
In order to prepare for linting JSDoc, I thought it would be a good idea to get
samsamcaught up with the other projects.That turned out to be more work than I anticipated 馃槷
Solution
no-prototype-methodsfromsinonHow to verify - mandatory
npm installnpm run lintChecklist for author
npm run lintpasses