refactor: Make 'nise' the default dependency of the constructor

sinonjs · Oct 24, 2023 · 44529c8 · 44529c8
1 parent 8e7f602
commit 44529c8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/lib/create-sinon-api.js b/lib/create-sinon-api.js
@@ -7,15 +7,17 @@ const fakeTimers = require("./sinon/util/fake-timers");
 const Sandbox = require("./sinon/sandbox");
 const stub = require("./sinon/stub");
 const promise = require("./sinon/promise");
+const nise = require("nise");
 const assert = require("assert");
 
 /**
  * @param {object} opts injection point to override the default XHR lib in testing
  * @param {object} opts.sinonXhrLib
  * @returns {object} a configured sandbox
  */
-module.exports = function createApi({ sinonXhrLib }) {
-    assert(sinonXhrLib, "No XHR lib passed in");
+module.exports = function createApi(opts = { sinonXhrLib: nise }) {
+    assert(opts?.sinonXhrLib, "No XHR lib passed in");
+    const { sinonXhrLib } = opts;
 
     const apiMethods = {
         createSandbox: createSandbox,

diff --git a/lib/sinon.js b/lib/sinon.js
@@ -1,6 +1,5 @@
 "use strict";
 
-const nise = require("nise");
 const createApi = require("./create-sinon-api");
 
-module.exports = createApi({ sinonXhrLib: nise });
+module.exports = createApi();