using more explicit assertions (#2221)

sinonjs · Feb 18, 2020 · 7498f1a · 7498f1a
1 parent 9d4a01b
commit 7498f1a
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 16 deletions.
diff --git a/test/fake-test.js b/test/fake-test.js
@@ -147,7 +147,7 @@ describe("fake", function() {
             assert.equals(f.firstArg, 46);
 
             f(false, true, 47, "string");
-            assert.equals(f.firstArg, false);
+            assert.isFalse(f.firstArg);
 
             f("string", false, true, 47);
             assert.equals(f.firstArg, "string");
@@ -156,7 +156,7 @@ describe("fake", function() {
             assert.equals(f.firstArg, 47);
 
             f(true, 47, "string", false);
-            assert.equals(f.firstArg, true);
+            assert.isTrue(f.firstArg);
 
             f();
             assert.isUndefined(f.firstArg);
@@ -182,10 +182,10 @@ describe("fake", function() {
             assert.equals(f.lastArg, 47);
 
             f(47, "string", false, true);
-            assert.equals(f.lastArg, true);
+            assert.isTrue(f.lastArg);
 
             f(true, 47, "string", false);
-            assert.equals(f.lastArg, false);
+            assert.isFalse(f.lastArg);
 
             f();
             assert.isUndefined(f.lastArg);

diff --git a/test/issues/issues-test.js b/test/issues/issues-test.js
@@ -612,7 +612,7 @@ describe("issues", function() {
 
             fake(99, false);
 
-            assert.equals(fake.lastArg, false);
+            assert.isFalse(fake.lastArg);
         });
     });
 

diff --git a/test/proxy-call-test.js b/test/proxy-call-test.js
@@ -180,19 +180,19 @@ describe("sinonSpy.call", function() {
                 return spy.getCall(idx);
             });
 
-            assert.equals(calls[1].calledBefore(calls[3]), true);
-            assert.equals(calls[1].calledBefore(calls[0]), false);
+            assert.isTrue(calls[1].calledBefore(calls[3]));
+            assert.isFalse(calls[1].calledBefore(calls[0]));
 
-            assert.equals(calls[3].calledAfter(calls[1]), true);
-            assert.equals(calls[1].calledAfter(calls[3]), false);
+            assert.isTrue(calls[3].calledAfter(calls[1]));
+            assert.isFalse(calls[1].calledAfter(calls[3]));
 
-            assert.equals(calls[0].calledImmediatelyBefore(calls[2]), false);
-            assert.equals(calls[1].calledImmediatelyBefore(calls[2]), true);
-            assert.equals(calls[3].calledImmediatelyBefore(calls[1]), false);
+            assert.isFalse(calls[0].calledImmediatelyBefore(calls[2]));
+            assert.isTrue(calls[1].calledImmediatelyBefore(calls[2]));
+            assert.isFalse(calls[3].calledImmediatelyBefore(calls[1]));
 
-            assert.equals(calls[3].calledImmediatelyAfter(calls[1]), false);
-            assert.equals(calls[2].calledImmediatelyAfter(calls[1]), true);
-            assert.equals(calls[1].calledImmediatelyAfter(calls[3]), false);
+            assert.isFalse(calls[3].calledImmediatelyAfter(calls[1]));
+            assert.isTrue(calls[2].calledImmediatelyAfter(calls[1]));
+            assert.isFalse(calls[1].calledImmediatelyAfter(calls[3]));
         });
     });
 
@@ -566,7 +566,7 @@ describe("sinonSpy.call", function() {
             assert.equals(spy.getCall(2).firstArg, 46);
 
             spy();
-            assert.equals(spy.getCall(3).firstArg, undefined);
+            assert.isUndefined(spy.getCall(3).firstArg);
         });
     });