Merge pull request #1140 from launchcg-ztonia/hasOwnProperty/override…

…/v1.17 Has Own Property Check in Core now compares vs Object prototype.
sinonjs · Dec 17, 2016 · 8663746 · 8663746
2 parents d11e51f + 50e4709
commit 8663746
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/lib/sinon/util/core.js b/lib/sinon/util/core.js
@@ -103,7 +103,8 @@
 
             // IE 8 does not support hasOwnProperty on the window object and Firefox has a problem
             // when using hasOwn.call on objects from other frames.
-            var owned = object.hasOwnProperty ? object.hasOwnProperty(property) : hasOwn.call(object, property);
+            var owned = (object.hasOwnProperty && object.hasOwnProperty === hasOwn) ?
+                object.hasOwnProperty(property) : hasOwn.call(object, property);
 
             if (hasES5Support) {
                 var methodDesc = (typeof method === "function") ? {value: method} : method;

diff --git a/test/mock-test.js b/test/mock-test.js
@@ -906,6 +906,31 @@
             }
         },
 
+        "mock object with hasOwnProperty": {
+            setUp: function () {
+                this.method = function () {};
+                this.hasOwn = function () {
+                    throw Error("overridden method hasOwnProperty invoked");
+                };
+                this.object = { method: this.method, hasOwnProperty: this.hasOwn };
+                this.mock = sinon.mock.create(this.object);
+            },
+
+            "mocks object method": function () {
+                this.mock.expects("method");
+
+                assert.isFunction(this.object.method);
+                refute.same(this.object.method, this.method);
+            },
+
+            "reverts mocked method": function () {
+                this.mock.expects("method");
+                this.object.method.restore();
+
+                assert.same(this.object.method, this.method);
+            }
+        },
+
         "mock method multiple times": {
             setUp: function () {
                 this.thisValue = {};