Support callable instances (#2517)

* Support callable instances * Clean prettier lint --------- Co-authored-by: - <->
sinonjs · Jun 20, 2023 · a79ccae · a79ccae
1 parent d220c99
commit a79ccae
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 1 deletion.
diff --git a/lib/sinon/proxy-invoke.js b/lib/sinon/proxy-invoke.js
@@ -43,7 +43,10 @@ module.exports = function invoke(func, thisValue, args) {
                 concat([thisValue], args)
             ))();
 
-            if (typeof returnValue !== "object") {
+            if (
+                typeof returnValue !== "object" &&
+                typeof returnValue !== "function"
+            ) {
                 returnValue = thisValue;
             }
         } else {

diff --git a/test/proxy-call-test.js b/test/proxy-call-test.js
@@ -1246,6 +1246,48 @@ describe("sinonSpy.call", function () {
         });
     });
 
+    describe("constructor return", function () {
+        it("preserves returned object", function () {
+            const customReturn = {};
+            function CustomConstructor() {
+                return customReturn;
+            }
+            const SpiedCustomConstructor = sinonSpy(CustomConstructor);
+            const myInstance = new SpiedCustomConstructor();
+
+            assert(myInstance === customReturn);
+        });
+
+        it("allows explicit returned object", function () {
+            const StubConstructor = sinonStub();
+            const customReturn = {};
+            StubConstructor.returns(customReturn);
+            const myInstance = new StubConstructor();
+
+            assert(myInstance === customReturn);
+        });
+
+        it("preserves returned function", function () {
+            function customReturn() {} // eslint-disable-line no-empty-function
+            function CustomConstructor() {
+                return customReturn;
+            }
+            const SpiedCustomConstructor = sinonSpy(CustomConstructor);
+            const myInstance = new SpiedCustomConstructor();
+
+            assert(myInstance === customReturn);
+        });
+
+        it("allows explicit returned function", function () {
+            const StubConstructor = sinonStub();
+            function customReturn() {} // eslint-disable-line no-empty-function
+            StubConstructor.returns(customReturn);
+            const myInstance = new StubConstructor();
+
+            assert(myInstance === customReturn);
+        });
+    });
+
     describe("functions", function () {
         it("throws if spying on non-existent property", function () {
             const myObj = {};