Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad check for canColor in color.js #1574

Closed
jgarver opened this issue Sep 28, 2017 · 1 comment · Fixed by #1583
Closed

Bad check for canColor in color.js #1574

jgarver opened this issue Sep 28, 2017 · 1 comment · Fixed by #1583

Comments

@jgarver
Copy link

jgarver commented Sep 28, 2017

Recently, color.js was introduced to replace the chalk module. It uses a simple check for "process" to determine if the environment can handle color. chalk used the more robust check provided by the supports-color module.

In my browserify world, I have the process module, so I end up with weird ansi color codes in my browser.
�[31mbad�[0m �[32mgood�[0m

Thanks!

@mroderick
Copy link
Member

Thank you for the bug report. Fancy making it into a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants