Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1.0 with supportsColor breaks testing on node < 4 #1607

Closed
Yeti-or opened this issue Nov 3, 2017 · 1 comment
Closed

4.1.0 with supportsColor breaks testing on node < 4 #1607

Yeti-or opened this issue Nov 3, 2017 · 1 comment

Comments

@Yeti-or
Copy link

Yeti-or commented Nov 3, 2017

I am complaining because sinon supports old node.js, it's written in package.json https://github.com/sinonjs/sinon/blob/master/package.json#L95

Okay, I understand that it is not mainstream, but I have a package that should be working on old env.
And everything was okay until release of 4.1.0.

But than supports-color was added: https://github.com/sinonjs/sinon/pull/1583/files#diff-dab05c918e781b4a65cc1fdbcdc6a7aaR3

Some options we could do:

  • drop support of old node.js, because as I see in .travis.yml you are not testing on it anyway
  • remove supports-color from dependencies
    and put necessary code from supports-color to lib/sinon/color.js
  • try to convince supports-color, to switch from const && let, to var but actually I am not believing in this option =/

Sinon version : 4.1.0

What did you expect to happen?
tests on node 0.12.0 works

What actually happens
no they not

@mantoni
Copy link
Member

mantoni commented Nov 3, 2017

The "engine" field in the package.json file is outdated and should be removed or corrected. The Sinon.js documentation page has a compatibility section wich states that Node 4 is the minimum requirement: http://sinonjs.org/releases/v4.1.0/

If you need Sinon on Node 0.12 please use Sinon 1.x. We require Node 4 since Sinon 2.

@mantoni mantoni closed this as completed Nov 3, 2017
mroderick added a commit that referenced this issue Nov 3, 2017
As discussed in #1607, this is outdated and should be removed
mroderick added a commit that referenced this issue Nov 3, 2017
As discussed in #1607, this is outdated and should be removed
franck-romano pushed a commit to franck-romano/sinon that referenced this issue Oct 1, 2019
As discussed in sinonjs#1607, this is outdated and should be removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants