-
-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document updates (fixes?) to (calls|resolves|returns|throws)Arg #1854
Labels
Comments
huttli
pushed a commit
to huttli/sinon
that referenced
this issue
Jul 17, 2018
huttli
pushed a commit
to huttli/sinon
that referenced
this issue
Jul 17, 2018
mroderick
pushed a commit
that referenced
this issue
Jul 18, 2018
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This was fixed in #1860 . |
This comment has been minimized.
This comment has been minimized.
The comment above is hidden. |
franck-romano
pushed a commit
to franck-romano/sinon
that referenced
this issue
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
6.1.2
, the way calls tocallsarg
,resolvesArg
,returnsArg
, andthrowsArg
handled not enough parameters changed/were fixed (via #1848).Example
Previously
result
would be set toundefined
since there is no argument at the 5th index. At6.1.2
, this functionality changed into aTypeError
being thrown since there aren't enough arguments to satisfy the request. Keep in mind thatcallsArg
would have always thrown aTypeError
here sinceundefined
is not afunction
. However the error message changed to match the others.These changes should be documented.
Note:
resolvesArg
was added in6.1.1
and always functioned this way. It didn't change like the others, but it also needs to be documented.The text was updated successfully, but these errors were encountered: