Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-built v6.1.3 uses old version of nise #1861

Closed
tzrh opened this issue Jul 17, 2018 · 7 comments
Closed

Pre-built v6.1.3 uses old version of nise #1861

tzrh opened this issue Jul 17, 2018 · 7 comments

Comments

@tzrh
Copy link
Contributor

tzrh commented Jul 17, 2018

Describe the bug
As in #1656, the pre-built version of sinon doesn't seem to include the correct version of nise.

To Reproduce
Steps to reproduce the behavior:

  1. Open http://sinonjs.org/releases/sinon-6.1.3.js
  2. Search for these lines from nise v1.4.2 (originally added in v1.4.0).
  3. Lines aren't included.

Expected behavior
http://sinonjs.org/releases/sinon-6.1.3.js should be built with the latest version of nise.

Context (please complete the following information):

@tzrh tzrh mentioned this issue Jul 17, 2018
2 tasks
@tzrh tzrh changed the title Pre-built v6.0.1 uses old version of nise Pre-built v6.1.3 uses old version of nise Jul 17, 2018
@mroderick
Copy link
Member

We need a better build process to ensure that this situation doesn't happen again.

@fatso83 do you have any ideas for this?

@mantoni
Copy link
Member

mantoni commented Jul 18, 2018

Maybe npm up lolex and npm up nise should be part of the build script?

tzrh added a commit to tzrh/sinon that referenced this issue Jul 18, 2018
Add warnings about outdated dependencies when building for release manually, to avoid sinonjs#1861.
@tzrh
Copy link
Contributor Author

tzrh commented Jul 18, 2018

I created a PR for one possible approach, but I'd be for updating the packages in the script as well. There might be a small risk that, since the build script doesn't run tests, updating the packages as part of the build could accidentally break something.

@tzrh
Copy link
Contributor Author

tzrh commented Jul 20, 2018

In the meantime, would it be possible to publish a minor release with the updated packages?

mroderick pushed a commit that referenced this issue Jul 21, 2018
Add warnings about outdated dependencies when building for release manually, to avoid #1861.
@mroderick
Copy link
Member

mroderick commented Jul 21, 2018

I used the updated preversion.sh to publish sinon@6.1.4, which has updated lolex and nise dependencies.

@tzrh can you verify that this works for you?

@tzrh
Copy link
Contributor Author

tzrh commented Jul 23, 2018

It looks good on my end. Thanks!

@mroderick
Copy link
Member

Thank you 👍

franck-romano pushed a commit to franck-romano/sinon that referenced this issue Oct 1, 2019
Add warnings about outdated dependencies when building for release manually, to avoid sinonjs#1861.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants