Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isNode removes DOM nodes and doesn't put them back... #6

Closed
peterwmwong opened this issue Dec 30, 2010 · 2 comments
Closed

isNode removes DOM nodes and doesn't put them back... #6

peterwmwong opened this issue Dec 30, 2010 · 2 comments

Comments

@peterwmwong
Copy link

8be9da1#L0R17

Introduced in 1.0.0, testing equality of nodes causes the nodes to be plucked from the current parent. I can't imagine this being desirable. :)

Maybe do this?
https://gist.github.com/759285

@cjohansen
Copy link
Contributor

Ah, that's very rude behavior indeed. I've fixed it in master: 083b66a

I took a slightly different approach, in an attempt to modify the element as little as possible.

@peterwmwong
Copy link
Author

Thanks for the quick response!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants