First execution of a spy as a method renames that spy

[glebec]

I find this quite bizarre. Is this intended behavior? It really conflicts with clear test output. Executing a spy as a method of an object renames that spy to the method name, but only once:

function bob () {}
var spy = sinon.spy(bob);
console.log(spy); // function bob

var obj = { methodName: spy };
console.log(spy); // function bob

spy();
console.log(spy); // function bob

obj.methodName.call(null);
console.log(spy); // function bob

obj.methodName();
console.log(spy); // function methodName

obj.otherProp = spy;
obj.otherProp();
console.log(spy); // function methodName

[mantoni]

I guess it's trying to be more helpful in other use cases. I agree that it looks weird when used the way you describe it here. Not sure whether this should be seen as a bug or if it's a feature with this behavior as a trade off.

[glebec]

If that's the case, it doesn't go far enough since it only can be "renamed" this way once. And from a test-writer's perspective, it's very unhelpful if you are trying to sort out many similar spies which you have carefully given different names, but they are all getting renamed to a single property name because my code happens to store functions in wrapper objects and execute them as methods.

If this is indeed a feature and not a bug, I think it should be deprecated.

[mantoni]

Would you be able to look at the Sinon sources and make a suggestion where to change it? I don't think anybody has "hard" dependencies on this, be it a bug or a feature - maybe there isn't even a specific intention behind it.

[glebec]

I can certainly go digging… not this week, but sometime.