Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fire .onprogress event handler in fake XHR #1175

Merged
merged 1 commit into from Nov 1, 2016
Merged

Fire .onprogress event handler in fake XHR #1175

merged 1 commit into from Nov 1, 2016

Conversation

dottedmag
Copy link

Purpose (TL;DR) - mandatory

xhr.onprogress was not fired by fake XHR, only .addEventListener('progress') handler was. Make it so.

How to verify - mandatory

  1. Check out this branch (see github instructions below)
  2. npm install
  3. npm test

@coveralls
Copy link

coveralls commented Oct 27, 2016 •
edited

Coverage Status

Coverage increased (+0.003%) to 96.377% when pulling 8ec51d3 on dottedmag:xhr-onprogress into 4ff653d on sinonjs:master.

@fatso83 fatso83 merged commit 1d76e11 into sinonjs:master Nov 1, 2016
@fatso83
Copy link
Contributor

fatso83 commented Nov 1, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dottedmag @coveralls @fatso83