Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for the new callsFake behavior #1325

Merged
merged 1 commit into from
Mar 13, 2017

Conversation

lucasfcosta
Copy link
Member

Purpose (TL;DR) - mandatory

This adds docs also containing an example to the callsFake method introduced in #1207.

Solution

I just added a new entry to the docs/release-source/release/stubs.md file for stub.callsFake with an example below its description.

I also made sure it was on top because I think this is one of the most used features for stubs we've got.

How to verify

  1. Check out this branch (see github instructions below)
  2. Go to the docs folder by running cd docs on Sinon's root folder
  3. Ensure you have bundler by running gem install bundler
  4. Install dependencies by running bundle install
  5. Run a local server by running bundle exec jekyll serve
  6. Generate a new version with npm version
  7. Go to http://localhost:4000 and check the new docs for the next release

@coveralls
Copy link

coveralls commented Mar 11, 2017

Coverage Status

Coverage decreased (-1.4%) to 93.963% when pulling bdd3f82 on lucasfcosta:callsFake-docs into e0cfccc on sinonjs:master.

@fatso83 fatso83 merged commit c748bc5 into sinonjs:master Mar 13, 2017
@fatso83
Copy link
Contributor

fatso83 commented Mar 13, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants