CircleCI Integration #1479

fearphage · 2017-07-03T14:53:41Z

I'm working on the CircleCI integration to potentially replace TravisCI. So far, the problem I'm having is I don't understand why the webworker test (test-webworker) is failing on Node 6 and 8. FYI it's not run on Node 4. I mostly copied the logic of the travis config into circle.

Notes: I'm using their new fancy 2.0 configuration which is new to me.

@sinonjs/sinon-core Any ideas? I can't reproduce locally and I don't see anything out of the ordinary. Is there a way to get any more feedback from the failure?

coveralls · 2017-07-03T14:58:23Z

Coverage remained the same at 94.998% when pulling 9c083f8 on fearphage:circleci-integration into 079925b on sinonjs:master.

coveralls · 2017-07-03T14:59:15Z

Coverage remained the same at 94.998% when pulling 9c083f8 on fearphage:circleci-integration into 079925b on sinonjs:master.

coveralls · 2017-07-03T14:59:15Z

Coverage remained the same at 94.998% when pulling 9c083f8 on fearphage:circleci-integration into 079925b on sinonjs:master.

fatso83 · 2017-07-03T15:03:48Z

sorry, no idea. this change smells a bit like the YAML vs JSON vs JS issue for me. Personally, I don't really care as long as it works, as it's just too little time saved to care, but remind me again why you are doing this; aren't these things pretty much the same?

lucasfcosta

As @fatso83 commented, are there any special reasons for doing this?

TravisCI has always worked well for me and it has great integration with many services. Have we been having any problems with it lately? Sometimes it could be easier to get in touch with their support and see if these problems can be solved so that we don't have to change infrastructure.

I'm not invalidating these changes, I think you've done great work with all this infrastructure changes, I just wanted to make sure we will avoid unnecessary work.

When it comes to why this test is failing, I've done a quick research and I think it might be because circleCI is trying to do cross-domain XHR. This StackOverflow answer might help you.

fearphage · 2017-07-03T19:19:24Z

this change smells a bit like the YAML vs JSON vs JS issue for me

It has nothing to do with the config file itself to my knowledge.

TravisCI has always worked well for me and it has great integration with many services. Have we been having any problems with it lately? Sometimes it could be easier to get in touch with their support and see if these problems can be solved so that we don't have to change infrastructure.

I just looked into, because of the problems with running tests in Node 8 on travis. I prefer CircleCI and that's what I've used professionally. I have yet to see an integration that Travis has over Circle. I'm just putting it out there as an option. I also like that it reports each node version individually instead of as a set. Thus you don't have to click through to see where the failures are.

This StackOverflow answer might help you.

Check out the actual build. It's running phantomic with that option:

browserify --no-commondir --full-paths -p [ mocaccino -R spec --color ] test/webworker/webworker-support-assessment.js | phantomic --web-security false

https://circleci.com/gh/fearphage/Sinon.JS/28

Node images default to Debian

coveralls · 2017-07-03T19:23:18Z

Coverage remained the same at 94.998% when pulling 310c83a on fearphage:circleci-integration into 079925b on sinonjs:master.

fatso83 · 2017-07-15T07:17:46Z

I didn't mean it was a config issue; I meant it was a superficial change that is functionally equivalent. As long as it works and doesn't make things harder it's all fine to me 😁

because of the problems with running tests in Node 8 on travis.

Which ones are that? I don't know of any. Superficially googled and came up with this, which seems to be a solved problem.

fatso83 · 2017-07-15T07:19:42Z

Sorry, I am an idiot. Just saw the list of PRs ... #1469, of course.

fatso83 · 2017-07-28T21:45:42Z

Two thoughts:

could it be that it picks up a phantomjs version on the local path, instead of the one we bundle? (Out on a limb with this one, but could explain the "works on my machine" issue)
try bumping the phantomic version to 1.5.2. We are on 1.4.0, but it only got official support for phantom 2.0 with version 1.5.2. I might not read the docs right, though ...

fatso83 · 2017-07-28T21:51:39Z

This issue is what made me think of it, btw. Might not be related, but could be.

mroderick · 2017-07-31T08:54:10Z

We should probably make it a priortiy to replace PhantomJS with headless chrome (#1405). We are likely to do this soon anyway, and it is likely to obviate many of these problems.

fatso83 · 2017-08-01T09:39:26Z

While researching #1498, I understood what the failing synchronous network request was. It simply happens because ./scripts/build.js (the prepublish step) has not been called before npm test is run. Therefore there is no ../../pkg/sinon.js to load in the webworker file. The importScripts() call in WebWorkers is synchronous, as they need to load the code before anything else is run.

I'll try to get this fixed as part of my #1498 fixes.

The WebWorker test in PR sinonjs#1479 seems to fail for some mysterious reason with a synchronous XHR requests. The reason was most probably the importScript('../../pkg/sinon.js') call in the webworker file was referencing a build file that wasn't built. By now explicitly building this file as part of the test run this error has now disappeared locally, and probably will disappear on CircleCI as well.

fatso83 · 2017-08-01T10:45:35Z

This should work as soon as #1504 lands.

fearphage · 2017-08-01T13:17:27Z

This should work as soon as #1504 lands.

Thanks for looking into this!

The WebWorker test in PR sinonjs#1479 seems to fail for some mysterious reason with a synchronous XHR requests. The reason was most probably the importScript('../../pkg/sinon.js') call in the webworker file was referencing a build file that wasn't built. By now explicitly building this file as part of the test run this error has now disappeared locally, and probably will disappear on CircleCI as well. fixes the build in sinonjs#1479

Fix build and test bugs in #1498 and #1479

…ration

fatso83 · 2017-08-01T17:54:02Z

No idea why you are getting EPEERINVALID

npm ERR! peerinvalid The package eslint@3.19.0 does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer eslint-config-sinon@1.0.3 wants eslint@^4.2.0
npm ERR! peerinvalid Peer eslint-plugin-mocha@4.11.0 wants eslint@^2.0.0 || ^3.0.0 || ^4.0.0

…ration

fatso83 · 2017-11-08T19:22:55Z

Hi, this has been building for quite a while. Any reason not to merge it (except for the history 😛 )? For some reason, it is already being used in other PRs here, even though it hasn't been merged to master 😄

fatso83 · 2017-11-13T08:48:35Z

Squashed and merged. Thanks, Phred!

The WebWorker test in PR sinonjs#1479 seems to fail for some mysterious reason with a synchronous XHR requests. The reason was most probably the importScript('../../pkg/sinon.js') call in the webworker file was referencing a build file that wasn't built. By now explicitly building this file as part of the test run this error has now disappeared locally, and probably will disappear on CircleCI as well. fixes the build in sinonjs#1479

Uses alpine docker image (Node images default to Debian)

fearphage added 7 commits July 1, 2017 16:42

added circleci 2.0 config

3565d13

refactoring to use workflows

dcff8a1

switch working dir

6c6d2f3

switch working dir again

9790c5d

copying from travis.yaml

b38cbed

more from travis.yaml

ad22c4f

empty commit to trigger build

9c083f8

lucasfcosta reviewed Jul 3, 2017

View reviewed changes

lucasfcosta mentioned this pull request Jul 3, 2017

Run tests on Travis in node 8 #1469

Merged

trying an alpine docker image

310c83a

Node images default to Debian

fatso83 mentioned this pull request Aug 1, 2017

Fix build and test bugs in #1498 and #1479 #1504

Merged

fatso83 added a commit that referenced this pull request Aug 1, 2017

Merge pull request #1504 from fatso83/fix-build-and-test-bugs

309dcef

Fix build and test bugs in #1498 and #1479

Merge branch 'master' of github.com:sinonjs/sinon into circleci-integ…

e0756ee

…ration

fearphage added 3 commits August 11, 2017 14:32

Merge branch 'master' of github.com:sinonjs/sinon into circleci-integ…

694d5c5

…ration

Merge branch 'master' of github.com:sinonjs/sinon into circleci-integ…

0459ca8

…ration

renamed builds to be more meaningful

73bf55e

fatso83 merged commit e96ff8c into sinonjs:master Nov 13, 2017

fearphage deleted the circleci-integration branch July 8, 2018 16:04

franck-romano pushed a commit to franck-romano/sinon that referenced this pull request Oct 1, 2019

CircleCI Integration (sinonjs#1479)

e49ce9e

Uses alpine docker image (Node images default to Debian)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CircleCI Integration #1479

CircleCI Integration #1479

fearphage commented Jul 3, 2017

coveralls commented Jul 3, 2017 •

edited

coveralls commented Jul 3, 2017

coveralls commented Jul 3, 2017

fatso83 commented Jul 3, 2017

lucasfcosta left a comment

fearphage commented Jul 3, 2017

coveralls commented Jul 3, 2017 •

edited

fatso83 commented Jul 15, 2017

fatso83 commented Jul 15, 2017

fatso83 commented Jul 28, 2017

fatso83 commented Jul 28, 2017

mroderick commented Jul 31, 2017

fatso83 commented Aug 1, 2017 •

edited

fatso83 commented Aug 1, 2017

fearphage commented Aug 1, 2017

fatso83 commented Aug 1, 2017

fatso83 commented Nov 8, 2017 •

edited

fatso83 commented Nov 13, 2017

CircleCI Integration #1479

CircleCI Integration #1479

Conversation

fearphage commented Jul 3, 2017

coveralls commented Jul 3, 2017 • edited

coveralls commented Jul 3, 2017

coveralls commented Jul 3, 2017

fatso83 commented Jul 3, 2017

lucasfcosta left a comment

Choose a reason for hiding this comment

fearphage commented Jul 3, 2017

coveralls commented Jul 3, 2017 • edited

fatso83 commented Jul 15, 2017

fatso83 commented Jul 15, 2017

fatso83 commented Jul 28, 2017

fatso83 commented Jul 28, 2017

mroderick commented Jul 31, 2017

fatso83 commented Aug 1, 2017 • edited

fatso83 commented Aug 1, 2017

fearphage commented Aug 1, 2017

fatso83 commented Aug 1, 2017

fatso83 commented Nov 8, 2017 • edited

fatso83 commented Nov 13, 2017

coveralls commented Jul 3, 2017 •

edited

coveralls commented Jul 3, 2017 •

edited

fatso83 commented Aug 1, 2017 •

edited

fatso83 commented Nov 8, 2017 •

edited