Fix more markdown #1603
Merged
Fix more markdown #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minimatch pattern in `package.json` was not matching anything at all. Currently, I can't figure out how to write a minimatch supported pattern that will "include any file from docs, but not `changelog.md`". Luckily, `changelog.md` should only be updated by `postversion.sh`, which doesn't have any human interaction. I've updated `postversion.sh` to bypass the pre commit hook.
fatso83
approved these changes
Nov 1, 2017
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Immediately after merging #1600 I discovered a trailing quote in one of the headings. During fixing that, I also discovered that the pre commit hook didn't run any validations for the changed markdown files.
This PR fixes both those issues.
To verify
docs/.<a href="asdf">asdf</a>works well for me.git add docs/git commitmarkdownlintaborts the commit and spits out an error message