Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for stub.yieldsRight #1845

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

nivsherf
Copy link
Contributor

Purpose (TL;DR) - mandatory

Adding missing documentation for stub.yieldsRight.

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. Review the stub docs.

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@coveralls
Copy link

coveralls commented Jun 16, 2018

Pull Request Test Coverage Report for Build 2638

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.324%

Totals Coverage Status
Change from base Build 2635: 0.0%
Covered Lines: 2029
Relevant Lines: 2083

💛 - Coveralls

@mroderick
Copy link
Member

Thank you for your pull request. This looks good to me. Would you mind also folding the changes into the older versions for which this applies?

@stale
Copy link

stale bot commented Sep 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 1, 2018
@nivsherf
Copy link
Contributor Author

nivsherf commented Sep 1, 2018

@mroderick Done. (Better late than never...)

@fatso83
Copy link
Contributor

fatso83 commented Sep 4, 2018

Thanks, @nivsherf. We know the "apply the change to older releases" step is troublesome. Did you find a way that made the process more slick for you? Would like to find some (semi-)automatic way of applying a patch to the older release docs.

@fatso83 fatso83 merged commit 8acad75 into sinonjs:master Sep 4, 2018
@nivsherf
Copy link
Contributor Author

nivsherf commented Sep 6, 2018

@fatso83 Well, in this case a simple replace did the trick. But since you asked, I also wrote a bash script that given a doc section and a semver number (e.g "stubs" and "4.1.1") will open the editor to edit the .md file for that version, then recursively do a 3-way merge on subsequent versions, stopping on conflicts so you can resolve them. A bit like "rebasing" the versioned docs. It's very basic and very poorly tested - mostly just a POC for myself... but I can share it if you're interested.

@nivsherf nivsherf deleted the documentYieldsRight branch September 6, 2018 20:42
@fatso83
Copy link
Contributor

fatso83 commented Sep 6, 2018

This is our weakest point, and increasingly a pain point, so if you could share the script in gist or something, that would be great.

@nivsherf
Copy link
Contributor Author

nivsherf commented Sep 6, 2018

@fatso83 Here's a gist.

@nivsherf
Copy link
Contributor Author

nivsherf commented Sep 8, 2018

Here is another version which works the other way around - it assumes changes were already made in release-source/ and propagates them to older versions. I guess this better fits your use-case, although it makes the conflict-resolution a bit less intuitive. Also handles editing the release.md file, which the previous version did not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants