-
-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for stub.yieldsRight #1845
Conversation
Pull Request Test Coverage Report for Build 2638
💛 - Coveralls |
Thank you for your pull request. This looks good to me. Would you mind also folding the changes into the older versions for which this applies? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
a024526
to
b88eeca
Compare
@mroderick Done. (Better late than never...) |
Thanks, @nivsherf. We know the "apply the change to older releases" step is troublesome. Did you find a way that made the process more slick for you? Would like to find some (semi-)automatic way of applying a patch to the older release docs. |
@fatso83 Well, in this case a simple replace did the trick. But since you asked, I also wrote a bash script that given a doc section and a semver number (e.g "stubs" and "4.1.1") will open the editor to edit the .md file for that version, then recursively do a 3-way merge on subsequent versions, stopping on conflicts so you can resolve them. A bit like "rebasing" the versioned docs. It's very basic and very poorly tested - mostly just a POC for myself... but I can share it if you're interested. |
This is our weakest point, and increasingly a pain point, so if you could share the script in gist or something, that would be great. |
Here is another version which works the other way around - it assumes changes were already made in |
Purpose (TL;DR) - mandatory
Adding missing documentation for
stub.yieldsRight
.How to verify - mandatory
npm install
Checklist for author
npm run lint
passes