Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated module #1989

Merged
merged 4 commits into from Mar 6, 2019
Merged

Replace deprecated module #1989

merged 4 commits into from Mar 6, 2019

Conversation

mgred
Copy link
Contributor

@mgred mgred commented Mar 6, 2019

Purpose (TL;DR) - mandatory

This PR removes the deprecated module and uses the future functionality from the @sinonsj/commons package (sinonjs/commons#13)

  • npm run test fails since @sinonjs/commons has not yet been released and updated in package.json

How to verify - mandatory

  1. Check out this branch
  2. npm install

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@mgred mgred self-assigned this Mar 6, 2019
@mroderick
Copy link
Member

@sinonjs/commons@1.4.0 is available now

@mgred mgred changed the title Remove deprecated Replace deprecated module Mar 6, 2019
@mgred mgred marked this pull request as ready for review March 6, 2019 16:32
@mgred mgred requested review from mroderick and mantoni and removed request for mroderick March 6, 2019 16:32
mantoni
mantoni approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@mantoni mantoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@fatso83 fatso83 merged commit b8679fa into sinonjs:master Mar 6, 2019
@mgred mgred deleted the remove-deprecated branch March 6, 2019 23:01
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2823

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 94.147%
Totals Coverage Status
Change from base Build 2822: 0.04%
Covered Lines: 1646
Relevant Lines: 1714
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantoni mantoni mantoni approved these changes

@mroderick mroderick Awaiting requested review from mroderick

Assignees

@mgred mgred

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mgred @mroderick @coveralls @mantoni @fatso83