Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document fake timer *Async() methods #2055

Merged
merged 4 commits into from
Dec 31, 2019

Conversation

dominykas
Copy link
Contributor

@dominykas dominykas commented Jul 3, 2019

Purpose (TL;DR) - mandatory

Adds documentation for new lolex features, introduced in sinonjs/fake-timers#105 (and its 2019 version: sinonjs/fake-timers#237)

This needs to stay a draft until the relevant functionality from lolex is merged, but feedback is most welcome.

How to verify - mandatory

https://github.com/sinonjs/sinon/blob/master/docs/CONTRIBUTING.md

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2912

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.186%

Totals Coverage Status
Change from base Build 2911: 0.0%
Covered Lines: 1660
Relevant Lines: 1729

💛 - Coveralls

@mroderick
Copy link
Member

Very nice!

@stale
Copy link

stale bot commented Sep 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 2, 2019
@dominykas
Copy link
Contributor Author

I still have to make an update to this based on sinonjs/fake-timers#237 (comment)

@stale stale bot removed the stale label Sep 2, 2019
@fatso83 fatso83 added the pinned label Sep 2, 2019
Copy link
Contributor

@fatso83 fatso83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thank you for doing this.

As stated in sinonjs/fake-timers#237, it would be nice with a little caveat on what to expect from runAllAsync, but it's not a blocker.

docs/release-source/release/fake-timers.md Outdated Show resolved Hide resolved
@dominykas dominykas marked this pull request as ready for review October 14, 2019 09:42
@dominykas
Copy link
Contributor Author

As stated in sinonjs/fake-timers#237, it would be nice with a little caveat on what to expect from runAllAsync, but it's not a blocker.

See sinonjs/fake-timers#237 (comment)

@fatso83
Copy link
Contributor

fatso83 commented Oct 14, 2019

As soon as we bump the version number for Lolex and the version used in Sinon, I guess we should merge this. Right?

@dominykas
Copy link
Contributor Author

Yeah, I suppose so. Not sure what's the release process here. Possibly this can be merged into whatever PR does the Lolex bumping?

@dominykas
Copy link
Contributor Author

sinon@8 is now out - this can probably now get merged?

@mroderick mroderick merged commit 43aaec0 into sinonjs:master Dec 31, 2019
@mroderick
Copy link
Member

@dominykas thanks! Once we cut the next release, this will be visible on the site.

@dominykas dominykas deleted the document-async-timers branch December 31, 2019 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants