Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove echo #2058

Merged
merged 1 commit into from Jul 10, 2019
Merged

Remove echo #2058

merged 1 commit into from Jul 10, 2019

Conversation

mroderick
Copy link
Member

@mroderick mroderick commented Jul 10, 2019 •
edited

Clearly a mistake... this was added in #2054

@mroderick
Remove echo
b09b467 
Clearly a mistake
@mroderick mroderick requested a review from fatso83 July 10, 2019 13:36
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2922

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.186%
Totals Coverage Status
Change from base Build 2921: 0.0%
Covered Lines: 1660
Relevant Lines: 1729
💛 - Coveralls

fatso83
fatso83 approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@fatso83 fatso83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, missed that ..

@fatso83 fatso83 merged commit 3f6db75 into sinonjs:master Jul 10, 2019
@mroderick mroderick deleted the remove-echo branch October 21, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatso83 fatso83 fatso83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mroderick @coveralls @fatso83