Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 2534: spies are not restored #2535

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Conversation

fatso83
Copy link
Contributor

@fatso83 fatso83 commented Aug 11, 2023

Purpose (TL;DR) - mandatory

Fix issue #2534 by ensuring spies on accessors are explicitly added to the sandbox collection

Background (Problem in detail) - optional

See #2534

How to verify - mandatory

Run the tests

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.26% ⚠️

Comparison is base (305fb6c) 95.99% compared to head (752986e) 95.73%.

❗ Current head 752986e differs from pull request most recent head 075ba36. Consider uploading reports for the commit 075ba36 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2535      +/-   ##
==========================================
- Coverage   95.99%   95.73%   -0.26%     
==========================================
  Files          40       40              
  Lines        1898     1901       +3     
==========================================
- Hits         1822     1820       -2     
- Misses         76       81       +5     
Flag Coverage Δ
unit 95.73% <100.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lib/sinon/sandbox.js 95.51% <100.00%> (-2.22%) ⬇️
lib/sinon/util/core/get-property-descriptor.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fatso83 fatso83 merged commit fe799e7 into sinonjs:main Aug 11, 2023
8 checks passed
@fatso83 fatso83 deleted the fix-2534 branch August 11, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant