Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: Remove sinon.defaultConfig and related modules #2565

Merged
merged 4 commits into from
Nov 2, 2023
Merged

breaking: Remove sinon.defaultConfig and related modules #2565

merged 4 commits into from
Nov 2, 2023

Commits on Oct 29, 2023

  1. breaking: Remove sinon.defaultConfig and related modules 

    default-config and get-config are leftovers from when Sinon
shipped with sinon.test (now the independent NPM module
 'sinon-test').

These serve no purpose internally, and really have no purpose
but to help sinon-test create a base default. If needed,
these can be copied into the sinon-test project. No projects
should depend on these (my assumption), but since it is a
change of the API we mark it as a breaking change

fixes sinonjs#2561
    @fatso83
    fatso83 committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    5eb187c View commit details
    Browse the repository at this point in the history

  2. fixed up tests that were lying 

    It seemed like the the 'injectInto' option
would expose most props by default. This was
not the case. That was formerly hidden by
using the getConfig call that added props
that were never used in the actual implementation.

Added another test to make this more explicit.
Will add docs on this.
    @fatso83
    fatso83 committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    023b62c View commit details
    Browse the repository at this point in the history

  3. Document Sandbox#inject 

    This was added in Sinon 0.6 but has never been documented
    @fatso83
    fatso83 committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    e3e6f37 View commit details
    Browse the repository at this point in the history

  4. Note that 'properties' is empty by default

    @fatso83
    fatso83 committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    94ee6d3 View commit details
    Browse the repository at this point in the history