feat(docs): overview of previously supported Node.js #2602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatso83
requested changes
May 29, 2024
|
|
||
| | Sinon.JS | supported Node.js | | ||
| |:--------:|:-----------------:| | ||
| | 18 | 18, 20, 22 | |
There was a problem hiding this comment.
Suggested change
| | 18 | 18, 20, 22 | | |
| | 18 | 18, 20 | |
You can use https://browserslist.dev/?q=bWFpbnRhaW5lZCBub2RlIHZlcnNpb25z or use npx browserslist directly to see that 22 is not yet in maintenance phase. We still run version 22 on CI to check that it works, but it's not supported yet :)
Comment on lines
+46
to
+52
| | 16 | 16, 18, 20 | | ||
| | 15 | 14, 16, 18 | | ||
| | 14 | 14, 16, 18 | | ||
| | 13 | 12, 14, 16 | | ||
| | 12 | 12, 14, 16 | | ||
| | 11 | 10, 12, 14 | | ||
| | 10 | 10, 12, 14 | |
There was a problem hiding this comment.
I am guessing the same applies. Usually there are just two LTS releases at any time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
fixes #2601
Background (Problem in detail)
For projects that are slower to upgrade the node version, it is difficult to find the correct sinon version, as the current LTS version is newer than the old one required by the projects. Currently it is difficult to find out which sinon version supports an old node version.
Solution - optional
Add overview of previously supported Node.js and the according Sinon.js version.
How to verify - mandatory
pass
Checklist for author
npm run lintpasses