Improve Blob support detection logics #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems legit to me. |
|
This also fixes tests run on phantom. |
fatso83
added a commit
that referenced
this pull request
Feb 29, 2016
Improve Blob support detection logics
|
@fatso83 Any chance this change could go into a 1.17.4 release? |
|
@pcardune: sure. Just supply a PR and the likelihood is quite high :-) |
|
@fatso83 I can do that. What steps do you follow for cutting new releases? Seeing as master is well on it's way to a 2.0 version, should I just submit a pull request against the v1.17 branch with just this change? I assume after merging, you'll go ahead and bump the version number in |
|
@pcardune Your assumptions are correct. I'll go ahead and merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Blob support detection returns false in Safari 9 for example where
typeof Blobisobject.This change is based on detection logics found in Modernizr.