Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError under Python 3.5 #4

Merged
merged 1 commit into from Sep 17, 2020

Conversation

mikenerone
Copy link
Contributor

Fixes #3

@sinoroc
Copy link
Owner

sinoroc commented Sep 17, 2020

Theoretically we should adjust the CI, etc. so that we test against Python 3.5 as well. But from a quick first try, seems like it would bring other breakages (with pytest-yapf3). But since the code change is so small maybe we could simply take the change without advertising Python 3.5 compatibility. It would be compatible by coincidence.

@sinoroc
Copy link
Owner

sinoroc commented Sep 17, 2020

Since I host the code on both GitHub and GitLab (and who knows where the code will land later on), I want to have elements of the commit messages that refer to a specific platform prefixed accordingly. It makes things clearer anyway. Something like:

Fix TypeError under Python 3.5

GitHub: fixes #3

Would you mind doing that?

@mikenerone
Copy link
Contributor Author

Of course, done. :)

@mikenerone
Copy link
Contributor Author

mikenerone commented Sep 17, 2020

But from a quick first try, seems like it would bring other breakages (with pytest-yapf3).

Perhaps you could exclude the yapf checks for the 3.5 run. Side note: I look forward to not using 3.5 myself and not caring about this. :D But for the moment, you know, constraints.

@sinoroc
Copy link
Owner

sinoroc commented Sep 17, 2020

Of course, done. :)

Thanks.

Perhaps you could exclude the yapf checks for the 3.5 run.

Yes. I have been meaning to revamp the whole thing for a while now, since there is no reason to do the whole linting, typing, formatting, etc. for each Python version (sometimes they even contradict each other). Once it's done, I will think about activating Python 3.5 in the CI.

I look forward to not using 3.5 myself and not caring about this. :D But for the moment, you know, constraints.

I get it. If it is truly needed then I will try to get the change in and publish a new release quickly.

@mikenerone
Copy link
Contributor Author

Many thanks!

@sinoroc sinoroc merged commit 357eb6e into sinoroc:develop-0.0.x Sep 17, 2020
@mikenerone mikenerone deleted the py35-compat-fix branch September 17, 2020 16:40
@sinoroc sinoroc mentioned this pull request Sep 28, 2020
sinoroc added a commit that referenced this pull request Sep 28, 2020
Run linting and type checking (make review) only on Python 3.8, and
on the other environments run only the test suite (make test).

As a side effect, Python 3.5 can be enabled in CI.

Some metadata bits were added as well.

GitHub: closes #19
GitHub: refs #18
GitHub: refs #4
@sinoroc sinoroc mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"TypeError: argument should be a path or str object, not <class 'py._path.local.LocalPath'>" with Python 3.5
2 participants