Consistency in naming convention

[mohammadbashiri]

Inconsistency from one table to another: for Model() table we have configurator, config_hash, and config_obj which could be more descriptive like other tables.
Inconsistency within one table: for Trainer() table we have both trainer and training. I suggest using trainer only.

[eywalker]

I totally agree with these suggestions. Let’s address them.

[KonstantinWilleke]

Yes these are good points, will address them in my next PR.
Right now, the functions all have three different names:
configurator(in the table), model_fn (in the builder)
dataset_loader (for datasets)
training_function (for trainer).

I'd suggest the following:
we go with _fn and _config for all of the parts. Also in the Table definitions. I think it's not too late for that.

so:
model_fn and model_config
dataset_fn ..
trainer_fn ..

What do you think?

[mohammadbashiri]

• dataloader -> dataloaders

[mohammadbashiri]

Addressed in PR #26