Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify function resolution/check and git logging #33

Merged
merged 4 commits into from
Jan 13, 2020
Merged

Simplify function resolution/check and git logging #33

merged 4 commits into from
Jan 13, 2020

Conversation

eywalker
Copy link
Member

  • The shared logic for performing function resolution is not placed inside builder and any function resolution is performed against the namespace of the builder module, matching the fact that when actually loading, that's where the name resolution is performed. Consequently, .models, .datasets and .training are no longer loaded inside main.py
  • Functionality of performing Git logging is not distilled into a separate decorator, so that the handling of git commits etc are not tightly coupled into the implementation of make method as was found in TrainedModel. This also means anyone can easily make use of the new gitlog decorator to perform logging of git repos.

These are subtle but quite substantial changes and would really like thorough review by the requested individuals.

@mohammadbashiri mohammadbashiri merged commit e6d383a into sinzlab:master Jan 13, 2020
KonstantinWilleke added a commit to KonstantinWilleke/nnfabrik that referenced this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants