Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIO-2475 Drop support for python 2.7 #57

Merged
merged 5 commits into from Apr 20, 2022
Merged

SIO-2475 Drop support for python 2.7 #57

merged 5 commits into from Apr 20, 2022

Conversation

mgr0dzicki
Copy link
Contributor

  1. Czy powinniśmy zmienić nazwy requirements_py3.txt, requirements_static_py3.txt na requirements.txt, requirements_static.txt?
  2. Co z użyciami six, które nie mają wbudowanego odpowiednika w Pythonie 3 i wymagałyby dopisania pomocniczych funkcji (ensure_text, ensure_str, ensure_binary, reraise)?
  3. Co z użyciami python2 w entrypoint_checks.sh i worker_init.sh?

@mgr0dzicki mgr0dzicki requested a review from accek as a code owner April 10, 2022 20:47
@twalen twalen self-requested a review April 11, 2022 06:36
twalen
twalen reviewed Apr 11, 2022
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@mgr0dzicki mgr0dzicki requested a review from tudny April 11, 2022 11:41
@mgr0dzicki mgr0dzicki removed the request for review from accek April 11, 2022 11:50
@twalen twalen self-assigned this Apr 11, 2022
tudny
tudny approved these changes Apr 16, 2022
View reviewed changes
Copy link
Member

@tudny tudny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me.

@twalen twalen merged commit fefd4cd into sio2project:master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twalen twalen twalen left review comments

@tudny tudny tudny approved these changes

Assignees

@twalen twalen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mgr0dzicki @twalen @tudny