Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIO-2452 Wbudowany edytor kodu #60

Merged
merged 10 commits into from
May 16, 2022
Merged

SIO-2452 Wbudowany edytor kodu #60

merged 10 commits into from
May 16, 2022

Conversation

andr729
Copy link
Member

@andr729 andr729 commented Apr 21, 2022

No description provided.

@andr729 andr729 requested a review from twalen as a code owner April 21, 2022 16:04
.vscode/settings.json Outdated Show resolved Hide resolved
oioioi/base/models.py Outdated Show resolved Hide resolved
Copy link
Member

@tudny tudny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First impression comments, not a proper review.

Copy link
Contributor

@twalen twalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix small issues and we can merge it

lang_tools_script.onload = function() {
ace.require("ace/ext/language_tools");
var editor = ace.edit("{{ editor_id }}");
//set_mode(editor, "c_cpp");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be removed

@@ -238,6 +238,7 @@ def problem_statement_zip_view(request, problem_instance, statement_id, path):
@enforce_condition(
has_any_submittable_problem, template='contests/nothing_to_submit.html'
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why new line?

@twalen twalen self-requested a review May 16, 2022 11:02
@twalen twalen merged commit bbf0bb4 into sio2project:master May 16, 2022
@kostca
Copy link

kostca commented Jul 21, 2022

If you turn on "Enable editor" in your profile settings, you are not able to use the editor in the problemset, as there's another toggle for the contests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants