Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile and CI workflows building Docker images on new releases #12

Merged
merged 14 commits into from
Apr 20, 2023

Conversation

LiquidPL
Copy link
Contributor

As mentioned in sio2project/oioioi#126, in this PR I'm adding a Dockerfile that builds a working Docker image for sioworkers. It might also be worth adding a GitHub Actions workflow that builds a new image after creating a new release, but I would prefer to consult with project maintainers on where the images should be published beforehand.

I've also noticed that there's an old Docker setup in docker/, however since it seems fairly old, I wasn't sure if it's being in active use, and if there's a point in updating it.

@A-dead-pixel
Copy link
Contributor

A-dead-pixel commented Jan 14, 2023

I think there should also be a way to set the concurrency and memory limit via external environment variables.

README.md Outdated Show resolved Hide resolved
@LiquidPL
Copy link
Contributor Author

I've cleaned up the readme file and setup.py file from references to Python 2. The actual code will still need to be refactored to target Python 3 specifically.

Additionally, I've added workflows to run the tests on every push, and to publish a Docker image on every new release (we need to decide where to publish said images, though).

@LiquidPL LiquidPL changed the title Add a Dockerfile Build Docker images on new releases Jan 21, 2023
@LiquidPL LiquidPL changed the title Build Docker images on new releases Add Dockerfile and CI workflows building Docker images on new releases Jan 21, 2023
@LiquidPL
Copy link
Contributor Author

LiquidPL commented Apr 3, 2023

I have updated the build action to push images to Docker Hub.

For it to work, the Docker Hub username and password/access token need to be configured as secrets in the repository settings:

  • REGISTRY_USERNAME holds the username,
  • REGISTRY_PASSWORD holds the password/token.

Docker's documentation recommends creating an access token for the purpose of pushing images.

Additionally, a sio2project/sioworkers repository needs to be created in Docker Hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants