Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading the post-analysis script from the classpath in Maven plugin #274

Closed
reckart opened this issue Nov 13, 2020 · 2 comments
Closed

Comments

@reckart
Copy link

reckart commented Nov 13, 2020

To better support the case where multiple Maven projects or modules want to make use of the japicmp-maven-plugin, it would come in handy if the plugin could load the post-processing script from the plugin classpath and not only from the file system.

E.g.

<plugin>              
  <groupId>com.github.siom79.japicmp</groupId>
  <artifactId>japicmp-maven-plugin</artifactId>
  <configuration>
    ...            
    <parameter>
      <!-- The post-analysis script is contained in "that-artifact-that-contains-my-post-analysis-script" -->
      <postAnalysisScript>japicmp/post-analysis-script.groovy</postAnalysisScript>
    </parameter>
    ...
  </configuration>
  <dependencies>
    <dependency>
      <groupId>my.group</groupId>
      <artifactId>that-artifact-that-contains-my-post-analysis-script<artifactId>
    </dependency>
  </dependencies>
</plugin>
@siom79
Copy link
Owner

siom79 commented Jan 23, 2021

Implemented and will be released with the next version.

@siom79 siom79 closed this as completed Jan 23, 2021
@siom79
Copy link
Owner

siom79 commented Mar 6, 2021

Fixed: 0.15.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants