Implement umask and rlimit in lfp_spawn #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added this functionality with different signatures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by jruby/jruby#6552 this implements setumask and setrlimit for lfp_spawn
I did refactor the internal file actions struct to be a tagged union, but if you'd prefer to stay linear I can undo that.
I also considered the more ffi-friendly signature
(lfp_spawn_file_actions_t *file_actions, int resource, rlim_t cur, rlim_t max)but as much as I like that as an end-user, I ended up going with the more standardstruct rlimit*signature hereFixes #28
Fixes #27