Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove backtick due to incompatibility with ie11 #4

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

mvcds
Copy link
Contributor

@mvcds mvcds commented Jul 11, 2020

I needed to support ie11 for a client and locally I had done this change, now I am forking and committing it.

Let me know if you want something more elaborate, like a flag to control whether or not support that lovely browser.

@sionzee
Copy link
Owner

sionzee commented Jul 13, 2020

Hey! Sorry for late response. I haven't received notification.
This change definitely makes sense! Thank you for your PR!

It needs a little bit more changes because single quote is valid html character.
eg.: <svg attr='test'> and it will break your change because the output will be:

export default '<svg attr='test'>...</svg>'

So I suggest to escape all single quote with escape character \.

I will accept the merge and modify it! Thank you very much.

@sionzee sionzee merged commit 2287acd into sionzee:master Jul 13, 2020
@sionzee
Copy link
Owner

sionzee commented Jul 13, 2020

@mvcds Hey! I have release 2.0.0 with more fixes. If you are still interested please let me know if it works for you.
Thank you. 🍻

@mvcds
Copy link
Contributor Author

mvcds commented Jul 14, 2020

Cool. I'll have holidays now so I cannot check for about one month. Is there anything I can help you later?

@sionzee
Copy link
Owner

sionzee commented Jul 14, 2020

That is fine! Enjoy your holidays! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants