Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor readability improvements, typo fix #10

Merged
merged 1 commit into from
Sep 24, 2018

Conversation

Sjors
Copy link

@Sjors Sjors commented Jul 14, 2018

  • add reference to BIP66 in addition to BIP62
  • state who picks ''e'' and ''s'' and does the revealing (less use of passive voice FTW)
  • explicitly state option 3 was chosen
  • remind reader where all the weird constants come from the sekp256k1 standard
  • add missing subscript i

@jonasnick
Copy link

I'm not really convinced that BIP66 is relevant here because it doesn't seem to be related to the type of malleability discussed in the BIP, but only to malleability in the encoding. Otherwise ACK.

@sipa sipa merged commit fcfd42f into sipa:bip-schnorr Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants