Use arrays instead of initializer lists for constexpr LinTrans #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works! ACK f6b31e7 |
|
ACK. Weird. |
|
Compiles-without-error ACK f6b31e7 |
sipa
added a commit
that referenced
this pull request
Dec 25, 2018
f6b31e7 Use arrays instead of initializer lists for constexpr LinTrans (Pieter Wuille) Pull request description: The existing construction is not strictly C++11 compliant, as `std::initializer_list<>` doesn't have a constexpr `.begin()`. Fixes #5. Tree-SHA512: 793b20ce9d35aa398f535d7dea68e1c5770f6f6c18552a030c0e5987117d289bd22bd4eaa6a114c243c81799c441d8d4be24c09f38191259b0618fff5fbb1036
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing construction is not strictly C++11 compliant, as
std::initializer_list<>doesn't have a constexpr.begin().Fixes #5.