Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update homer.min.css #49

Closed

Conversation

heytensai
Copy link

Use https for google fonts. Eliminates warning when Homer is on an SSL site.

@lmangani
Copy link
Member

We cannot accept merge requests on minified files but i see the proposal here.
I think the proper case would be "//fonts.googleapis.com" to support both http/s based on the originating session - applies to other libraries/includes as well.

@heytensai
Copy link
Author

To be honest, I couldn't see where the minified files came from, so I threw out the pull request to at least start a conversation. If you can find a better way then I'm good with that too.

@lmangani
Copy link
Member

Absolutely not your lack, thanks for bringing this to attention! could you instead open an issue outlining the case?

@lmangani lmangani closed this Dec 21, 2015
@heytensai heytensai deleted the heytensai-googlefonts-https branch December 21, 2015 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants