Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option for base-href #573

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Conversation

radicaldrew
Copy link
Contributor

issue when running homer-webapp from a subdirectory such as /homer
assets do not load correctly since base href is /
please review if this is a good option.

@CLAassistant
Copy link

CLAassistant commented Feb 10, 2022

CLA assistant check
All committers have signed the CLA.

@lmangani
Copy link
Member

lmangani commented Feb 10, 2022

Thanks @radicaldrew for contributing a solution. Please sign the CLA so the change can be reviewed & merged in.

EDIT: you were faster than me

@radicaldrew radicaldrew reopened this Feb 10, 2022
@radicaldrew
Copy link
Contributor Author

radicaldrew commented Feb 10, 2022

@lmangani your welcome, this needs to be tested further but this would help me out alot. Thanks
I have another issue when building, because the package.json uses latest version and the docker build
does npm install and build fails because of latest version changes. If you want me to fix and send another pull request please let me know.

@adubovikov
Copy link
Member

please remove console.log

@radicaldrew
Copy link
Contributor Author

please remove console.log

Removed console.log Thanks

src/index.html Outdated Show resolved Hide resolved
@adubovikov
Copy link
Member

@radicaldrew
unfortunately the patch breaks share link and another components. We changed it a bit and you can provide the path in the index.html right now (static) We are working on a new solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants