Add enum strategy

[hr-ireh]

Add enum strategy based on parent class

[luc-boussant]

Hello @hr-ireh, thank you for creating this MR.
I will read this MR by friday next week.
I will update you with the remarks that I may have.

[luc-boussant]

Hello @hr-ireh, when I try to compile your code I am getting an Ant build error.
Can you please check that there is no compilation problems on your end please ?

Here is the error that i am having :

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run (ktlint) on project spring-search: An Ant BuildException has occured: Java returned: 1
[ERROR] around Ant part ...<java fork="true" classname="com.pinterest.ktlint.Main" taskname="ktlint" failonerror="true" dir="/***/spring-search" classpathref="maven.plugin.classpath">... @ 4:195 in /***/spring-search/target/antrun/build-ktlint.xml

[luc-boussant]

Hello @hr-ireh, i finished reading the MR, if you have any questions or remarks don't hesitate :)

[hr-ireh]

Hello @hr-ireh, when I try to compile your code I am getting an Ant build error.
Can you please check that there is no compilation problems on your end please ?

Here is the error that i am having :

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run (ktlint) on project spring-search: An Ant BuildException has occured: Java returned: 1
[ERROR] around Ant part ...<java fork="true" classname="com.pinterest.ktlint.Main" taskname="ktlint" failonerror="true" dir="/***/spring-search" classpathref="maven.plugin.classpath">... @ 4:195 in /***/spring-search/target/antrun/build-ktlint.xml

Hello
I'm checking, I think the problem is with the settings.

[luc-boussant]

Hello @hr-ireh, when I try to compile your code I am getting an Ant build error.
Can you please check that there is no compilation problems on your end please ?
Here is the error that i am having :

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run (ktlint) on project spring-search: An Ant BuildException has occured: Java returned: 1
[ERROR] around Ant part ...<java fork="true" classname="com.pinterest.ktlint.Main" taskname="ktlint" failonerror="true" dir="/***/spring-search" classpathref="maven.plugin.classpath">... @ 4:195 in /***/spring-search/target/antrun/build-ktlint.xml

Hello
I'm checking, I think the problem is with the settings.

I am still getting the same error on my end :) Let me know when you have resolved the issue or if you need help on it

[hr-ireh]

Hello @hr-ireh, when I try to compile your code I am getting an Ant build error.
Can you please check that there is no compilation problems on your end please ?
Here is the error that i am having :

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run (ktlint) on project spring-search: An Ant BuildException has occured: Java returned: 1
[ERROR] around Ant part ...<java fork="true" classname="com.pinterest.ktlint.Main" taskname="ktlint" failonerror="true" dir="/***/spring-search" classpathref="maven.plugin.classpath">... @ 4:195 in /***/spring-search/target/antrun/build-ktlint.xml

Hello
I'm checking, I think the problem is with the settings.

I am still getting the same error on my end :) Let me know when you have resolved the issue or if you need help on it

Hello @luc-boussant
In the User class, line 46 :(
Please check again

[luc-boussant]

@hr-ireh The code seems perfect for me ! However, you are going to get an error with circleci because you don't meet the coverage check.
Sorry 0.74 instead of 0.75.

[luc-boussant]

If you test a not equals with an enum it might be enough :)

[hr-ireh]

Unfortunately I can not see the test report :(

circleci.com: "CircleCI Terms of Service Violation: Sanctioned Country"

[luc-boussant]

CircleCI Terms of Service Violation: Sanctioned Country

Here is an extract of the output :

[WARNING] Rule violated for bundle spring-search: branches covered ratio is 0.74, but expected minimum is 0.75
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  30.876 s
[INFO] Finished at: 2021-03-11T16:26:29Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.4:check (jacoco-check) on project spring-search: Coverage checks have not been met. See log for details. -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

If you want you can launch the test by using the mvn test command line. It will check the coverage threshold.

I am sorry for the many back and forth we are having... But, thank you so much for contributing to the project !
I am working on a contributing markdown a bit more detailed to make it easier to contribute to the project !

[hr-ireh]

CircleCI Terms of Service Violation: Sanctioned Country

Here is an extract of the output :

[WARNING] Rule violated for bundle spring-search: branches covered ratio is 0.74, but expected minimum is 0.75
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  30.876 s
[INFO] Finished at: 2021-03-11T16:26:29Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.4:check (jacoco-check) on project spring-search: Coverage checks have not been met. See log for details. -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

If you want you can launch the test by using the mvn test command line. It will check the coverage threshold.

I am sorry for the many back and forth we are having... But, thank you so much for contributing to the project !
I am working on a contributing markdown a bit more detailed to make it easier to contribute to the project !

Thank
I checked and made the changes
The test result was this

I hope my work is useful and I have been able to help