Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version (6.2..1) introduced a bug #1079

Open
nganju98 opened this issue Mar 1, 2024 · 1 comment
Open

Latest version (6.2..1) introduced a bug #1079

nganju98 opened this issue Mar 1, 2024 · 1 comment

Comments

@nganju98
Copy link

nganju98 commented Mar 1, 2024

src/net/RTP/RTPSession.cs has a bug where lower case codecs won't map with Enum.Parse, because all the enums are upper case (PCMU vs pcmu). This bug was introduced by line 1032 in RTPSession.cs, where it says
currentMediaStream.LocalTrack.Capabilities = capabilities;

Steps to reproduce: just run the SIPCallServer example, and call the server with a SIP Invite that wants pcmu (lower case) as the audio codec. You'll get a bunch of errors that say "Can't encode to unknown codec" because the AudioFormat is unknown because it failed to map "pcmu" to the enum PCMU.

@ChristopheI
Copy link
Collaborator

I don't think the line 1032 in RTPSession.cs is the cause.
But the way to check codec is somewhere incorrect.
I don't use SIP neither PCMU ... So could you try to find where the test is incorrect ?

By the way SDPAudioVideoMediaFormat.AreMatch() is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants