Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase dependency versions, Fix breaking changes in Cypress 5 #10

Merged
merged 1 commit into from Feb 19, 2021

Conversation

DevAtHeart
Copy link

@DevAtHeart DevAtHeart commented Jan 31, 2021

Hi, I hope all is well, since I've seen that you haven't been active for a while.

This PR is basically for enabling usage with Cypress 5 (and 6 for that matter).

Closes #8.

@sir-dunxalot
Copy link
Owner

Thanks! LGTM. Merged and will release soon, perhaps without passing tests if I cannot soon solve the test suite issues identified in #6.

@sir-dunxalot
Copy link
Owner

Released with 1.0.0. Thanks again @DevAtHeart!

@DevAtHeart
Copy link
Author

Thank you so much!

@cajimhe
Copy link

cajimhe commented Feb 22, 2021

@sir-dunxalot I'm looking at the /dist folder of the freshly installed 1.0.0 and these fixes aren't there (still getting the whitelist error).

@sir-dunxalot
Copy link
Owner

@cajimhe Good catch! Perhaps the build command errored silently? I'll explore and will double-check /dist after release of a patch.

@sir-dunxalot
Copy link
Owner

sir-dunxalot commented Feb 25, 2021

This has been a weird rabbit hole but I believe release 1.0.1 fixes the issue. The correct dist code is now deployed to NPM. For good measure, I've added a release command to this package to standardize the release process and catch errors.

@DevAtHeart @cajimhe @marklawlor I'd appreciate it if you can upgrade this module to 1.0.1 and confirm everything is working fine because I don't have an active project using this module and typescript. In other words, 1.0.1 released dist support for #6 that I am not easily able to test myself.

@cajimhe
Copy link

cajimhe commented Feb 25, 2021

@sir-dunxalot seems to be working fine now. The whitelist error has gone and I could login with my credentials. Thanks dude :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Cypress 5 support
3 participants