observe changes to options, fix merge with defaultOptions issue #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good! This will be a good feature add. The test suite is failing but it appears to be unrelated to these changes. Can you please confirm that's the case before I merge into master? |
Merged
|
After looking at #15 it seems like the test suite is having issues in multiple places so I'm just going to merge these into master now and I will look at the test suite before releasing. |
sir-dunxalot
pushed a commit
that referenced
this pull request
Mar 16, 2016
observe changes to options, fix merge with defaultOptions issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue due to
Ember.merge()modifyingdefaultOptions.Adds observer for re-rendering on change to
options.