Fix: Error in Ember 3.0 when onDestroy action is sent #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sir-dunxalot Can you please give this a look soon? My team is wanting to upgrade to Ember 3.0, but this error is causing our builds to fail. |
This was referenced Jul 18, 2018
|
Glad to at least find a quick fix branch, even if the owner has gone awol. Thanks @mattgraham1995 |
josh-southern
added a commit
to josh-southern/ember-tooltips
that referenced
this pull request
Jul 24, 2018
josh-southern
added a commit
to josh-southern/ember-tooltips
that referenced
this pull request
Jul 24, 2018
maxfierke
added
3.x
maxfierke
approved these changes
Aug 23, 2018
there's a few other release-blocking issues with Ember 3.x compatibility that I'm looking into, but this is a good step forward. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #247
In Ember 3.0, the
sendActionmethod now has an assert in it that checks forthis.isDestroyedandthis.isDestroying. ThewillDestroyhook is reached afterthis.isDestroyingis set to true. Thehide()method would just return ifisDestroyingwas true, but since we are calling it when it is no longer true, we just check if the element is shown instead.