Replace ember-wormhole with ember-maybe-in-element #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ember-maybe-in-element leverages the Glimmer native helper to render content into another DOM node. This allows us to drop ember-wormhole and may address the issues raised in #309.
Closed
| @@ -160,6 +160,14 @@ export default Component.extend({ | |||
| return `${this.get('elementId')}-wormhole`; | |||
| }), | |||
|
|
|||
| wormholeEl: computed('wormholeId', '_awaitingTooltipElementRendered', function() { | |||
There was a problem hiding this comment.
Is wormhole a misnomer now?
There was a problem hiding this comment.
Depends on how you look at it, I guess. Conceptually, it's still a bit of a wormhole.
There was a problem hiding this comment.
An alternative would maybe be portal? I think that's what React calls their wormholes.
|
Please see my comment on the issue #309 (comment), this actually breaks the tooltip in my case. |
|
Going to close this for now. I think it's definitely something to look into later, but also might be better off implementing something ourselves with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-maybe-in-element leverages the Glimmer native
-in-elementhelper to render content into another DOM node. This allows us to
drop ember-wormhole and may address the issues raised in #309.