Moves ember-beta to the list of allow_failures
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many builds are failing for this. While it is important to be aware of this failures and try to fix them in advance, I don't think they should necessarily be a blocker for CI and it might be better to have a separate issue to address these failures.
|
Sounds good to me - thanks for taking the time to think about this. Merging now. I will come back to this to try and ascertain why ember-beta is failing so badly in the future. |
Closed
|
@sir-dunxalot thanks for merging it, it will help other PRs get a green build. I created #87 as a reminder to fix this and make it easier to track it, I think @andrew-zenefits was also thinking of doing something about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many builds are failing for this. While it is important to be aware of this failures and try to fix them in advance, I don't think they should necessarily be a blocker for CI and it might be better to have a separate issue to address these failures.