Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config setting to always re-create config files #9

Closed
sir-wilhelm opened this issue Feb 14, 2020 · 3 comments
Closed

Add a config setting to always re-create config files #9

sir-wilhelm opened this issue Feb 14, 2020 · 3 comments

Comments

@sir-wilhelm
Copy link
Owner

It might be good to default this to on. This would allow the standard user to just get updates and have the player data, monster data, and localization data always update.

If someone wants to tinker they could turn it off.

I'd want to have solid startup messages to indicate the change.

@sir-wilhelm
Copy link
Owner Author

I'm going to default to making a backup of the .json files and replacing them with the calculated version. I'll just add a message for a config option to "UseCustomData" to load user data files.

@sir-wilhelm
Copy link
Owner Author

This will be a larger change than I expected since it loads all the config files at the same time. If it loaded the Config.json first and we could use those settings to dictate if we import the others do.

I'm not quite willing to add the hack needed for ConfigContainer to handle it.

I'll just settle for #10 to tell people to delete .json files after an update.

@sir-wilhelm
Copy link
Owner Author

I changed my mind, the hacky approach is ugly but I think will work perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant